-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix blog archive heading to show "Month Year archive" #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@ManshaAgarwal716 can you rebase the PR on main. That should hopefully resolve the failing CI. Let me know if you need any help. |
This reverts commit a2a11c9.
This was requested by the fundraising working group. I abstracted the top `CorporateMember` display from the `releases` app sidebar into a new inclusion tag called `top_corporate_members` and included it in its original place as well as in the `docs` sidebar as requested. Uploaded images for `CorporateMember`s may not display in local development environments do to the way media files paths work with subdomains.
Helps with reproducible builds
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.38.0 to 2.39.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.38.0...2.39.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-version: 2.39.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This change was requested for simplicity and accessibility.
…2223) Fixes django#2158. Added `Cache-Control` header to never cache draft blog posts (since we want changes to be reflected immediately). Django's cache middleware will not cache responses when the Cache-Control header is set to no-cache, no-store, or private, which is our case here for draft blog posts. Co-authored-by: Tobias McNulty <[email protected]>
This branch adds a new view that replaces the Roadmap wiki pages, e.g.: * https://code.djangoproject.com/wiki/Version5.2Roadmap * https://code.djangoproject.com/wiki/Version6.0Roadmap * https://code.djangoproject.com/wiki/Version6.1Roadmap The wiki pages were almost identical except for version-specific details and target dates. This information is now generated dynamically from the Release model in the database. The supported and future Roadmap tables were reorganized so they follow a more intuitive timeline (from older to newer versions).
Have done sir, you can once checkout the changes and if anything else is required do let me know. |
{% block content %} | ||
|
||
<h1>{% blocktranslate %}{{ month|date:"YEAR_MONTH_FORMAT" }} archive{% endblocktranslate %}</h1> | ||
<h1>{{ month|date:"F Y" }} {% translate "archive" %}</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct way to make this title translatable, because different languages will use different word order and might want to have the word "archive" appear before the date for example.
The correct fix is to use {% blocktranslate with ... %}
: https://docs.djangoproject.com/en/5.2/topics/i18n/translation/#blocktranslate-template-tag
Summary
Fixes the heading on monthly blog archive pages, which was showing only "archive" instead of "Month Year archive".
Details
Related
Regression from #1669